[Themes][Feature] Theme Dev Preview - Initialize the ThemeEnvironment #3841
Conversation
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
jamesmengo
changed the title
jamesmengo
added
Type: Enhancement
Coverage report
Test suite run success1633 tests passing in 763 suites. Report generated by 🧪jest coverage report action from cd3689a |
There was a problem hiding this comment.
Thank you, @jamesmengo! This PR is in a great direction!
I've noticed that we have some Ruby-specific code we can skip, so I created this PR to share how we could do that and also included some other minor ideas. Please let me know what you think :)
Thanks again for this PR!
jamesmengo
force-pushed
the
jmeng/themedevbeta
branch
from
eedf2e3
to
d351340
Compare
- Upload Theme to Target Theme
jamesmengo
force-pushed
the
jmeng/theme_env_ci_reset
branch
from
3268eec
to
8ab646a
Compare
…LI2 specific logic
jamesmengo
force-pushed
the
jmeng/theme_env_ci_reset
branch
from
7698da0
to
cd3689a
Compare
| await startDevServer(developmentTheme, context, () => {}) | ||
|
|
||
| // Then | ||
| expect(uploadTheme).not.toHaveBeenCalled() |
There was a problem hiding this comment.
I believe this is going to change with #3833 but +1 for keeping it as is and updating in the following PR :)
jamesmengo
added
the
#gsd:40767
WHY are these changes introduced?
WHAT is this pull request doing?
theme devwith thedeveloper-previewflag--theme-editor-syncfunctionality. Passing the flag will, however, skip the uploadHow to test your changes?
pnpm shopify theme dev --path=<PATH_TO_THEME> --developer-previewCode.-.theme.src_cli_utilities_theme-environment.ts.CLI.Workspace.mp4