Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default values for flow templates #4068

Closed
wants to merge 1 commit into from

Conversation

tommybae
Copy link
Contributor

Fixes missing values in

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.02% (-0.14% 🔻)
7368/10231
🟡 Branches
68.78% (-0.35% 🔻)
3611/5250
🟡 Functions
71.54% (-0.13% 🔻)
1953/2730
🟡 Lines
73.28% (-0.15% 🔻)
6949/9483
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / app_config_webhook_subscription.ts
63.64% (-36.36% 🔻)
0% (-66.67% 🔻)
50% (-50% 🔻)
63.64% (-36.36% 🔻)
🟢
... / write-app-configuration-file.ts
95.65% (-0.27% 🔻)
93.1% (-0.84% 🔻)
100%
97.67% (-0.1% 🔻)
🟢
... / ConcurrentOutput.tsx
98.39% (-1.61% 🔻)
90.91% (-4.55% 🔻)
100%
98.33% (-1.67% 🔻)
🔴
... / system.ts
5.26% (-21.05% 🔻)
0% (-20.69% 🔻)
25% (-25% 🔻)
5.56% (-22.22% 🔻)

Test suite run success

1700 tests passing in 792 suites.

Report generated by 🧪jest coverage report action from 174c208

@tommybae tommybae closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant