Function log replay correlation #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1715 tests passing in 794 suites. Report generated by 🧪jest coverage report action from 91ad416 |
DuncanUszkay1
force-pushed
the
function-log-replay-correlation
branch
from
272feb1
to
dbf0741
Compare
andrewhassan
approved these changes
Jun 20, 2024
DuncanUszkay1
force-pushed
the
function-log-replay-correlation
branch
3 times, most recently
from
0c18220
to
65a8807
Compare
DuncanUszkay1
force-pushed
the
function-log-replay-correlation
branch
from
65a8807
to
91ad416
Compare
|
Going to wait until the log command ships, to avoid introducing any conflicts. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/shopify-functions/issues/245
Makes it easier to go from seeing a function execution in
app dev, to using it inreplay.WHAT is this pull request doing?
Adds the log "identifier" to the
app devoutput, to further differentiate each execution:... and provide a string that can be used when searching for logs in
replay:... or to feed into the new
--logargument ofreplayto bypass the manual selection:How to test your changes?
Use
app dev, then copy the identifier into areplayexecution using the--logargument.Checklist
devordeployhave been reflected in the internal flowchart.