Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Facets] dynamic header #3048

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[Facets] dynamic header #3048

merged 1 commit into from
Oct 6, 2023

Conversation

patrickracicot
Copy link
Contributor

PR Summary:

Following the latest changes to the facets which enabled dynamic updates to the counts, we've introduced a bug where the x Selected headers would no longer update for the current active filter on horizontal display mode.

Why are these changes introduced?

Fixes the regression issue

What approach did you take?

JS update logic now properly looks for the facets__header container and updates the internal text of it when re-rendering the counts.

Checklist

jas7457
jas7457 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@jas7457 jas7457 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and this seems to fix the issue

@patrickracicot patrickracicot merged commit fdd6905 into main Oct 6, 2023
9 checks passed
@patrickracicot patrickracicot deleted the pracicot/facet_dynamic_header branch October 6, 2023 14:58
@jas7457 jas7457 mentioned this pull request Oct 6, 2023
Merged
8 tasks
hz70ma added a commit to hz70ma/dawn that referenced this pull request Jan 31, 2024
@hz70ma @translation-platform
@ludoboludo @patrickracicot @eugenekasimov @jas7457 @sofiamatulis @lougoncharenko @tyleralsbury @kjellr @melissaperreault @KaichenWang @alisterdev @hamideha @charlespwd
merge from origin (#1)
181bdeb 
* Update 1 translation file (Shopify#2997)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#3001)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Image_tag] Update to remove lazy loading and let it automatically decide the best loading strategy (Shopify#3002)

* remove lazy loading where necessary to better performance

* add fetch priority

* [Facets] update filter counts on filter selection (Shopify#2988)

* Correct CSS (Shopify#3003)

* Check if there is compare_at_price (Shopify#3000)

* Update 1 translation file (Shopify#3012)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Facets] fix mobile count update (Shopify#3018)

* Update 1 translation file (Shopify#3043)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#3044)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Image with text] Add color scheme picker for section wrapper (Shopify#3016)

* [Image with text] Add color scheme picker for section wrapper

* address review comment about overlap and transparency

* Refactor `quick-order-list.css` (Shopify#3006)

* Fix Add to Cart error on page load/slower connections (Shopify#3008)

* [Facets] dynamic header (Shopify#3048)

* Add component-card.css to cart drawer (Shopify#3049)

* [Refactoring] Replace loading spinner with snippet (Shopify#2996)

* Change spinner for main-cart-items

* Change spinner for cart-drawer

* remove extra div and change classes

* Replace spinner with snippet for pdp and fead prod

* Remove unnecessary classes

* Add comment for snippet

* Change naming for files and css classes

* Put back deleted elements

* Remove unused classes

* Put back loading-overlay for cases when no spinner

* Chnage loading-overlay--error name

* Minor change in CSS

* Move loading-overlay styles to template-collection

* Rename component-loading-overlay

* Fix bug with overlay and spinner for facets

* Remove component-loading-spinner import from files

* Use spinner snippet for predictive search

* Hide product count when loading for drawer filters

* Address feedback. Clean-up.

* Minor changes to address feedback

* Fix spinner conflict with cart drawer

* Address feedabck

* Add missing whitespace for if tag

* [Sliders] Regression fix. Apply CSS only when necessary in theme editor (Shopify#3070)

* [Sliders] Regretion fix. Apply CSS only when necessary in theme editor

* change of approach

* add comment to explain CSS

* Add visual representation for filters (Shopify#3045)

* [Facets] update visual representation of facets operators (Shopify#3061)

* [Collection template] Product grid color scheme picker (Shopify#3017)

* [Collection template] Product grid color scheme picker]

* move color setting up in the list

* support gradient

* [Cart] Add color picker on cart page and in general cart settings (Shopify#3021)

* rebase final final

* use the update for the loading spinner

* add color picker for the cart drawer and cart popup

* fix spacing issues on cart page

* add gradient support

* address review comments

* adjust where the class is added. Fix gradient issue

* isolation needed for shadow

* add comment

* Remove unnecessary isolate

* use the isolate class instead

* [Product] Add color scheme picker (Shopify#3015)

* [Product] Add color scheme picker

* support gradient

* apply background color to be full width

* address review comments: color scheme applied to quick add modal and lightbox modal

* add color scheme to product availability drawer and move color settings up

* fix color classes to work properly with gradients

* Add support for gradient on modal

* remove console log

* [VisualDisplay] bump the active outline width (Shopify#3083) (Shopify#3091)

* 12.0.0 Version Bump and release notes (Shopify#3092)

* Update 1 translation file (Shopify#3093)

* updated code to match new color scheme naming (Shopify#2801)

* updated code to match new color scheme naming

* removing additional background-1 after rebase

* Fixed race condition for cart note updates (Shopify#3125)

* [Facets] support dynamic facet lists (Shopify#3123)

* Assign font family to input fields (Shopify#2871)

* Price per item, Popover and global style bugs (Shopify#2851)

* Fix cart submission on Quick Order List (Shopify#2868)

* Social icons: Visual fixes (Shopify#2855)

* Adjust spacing.

* Facebook + Tumblr icon size adjustments.

* Update social icon SVGs.

* Tidy up new icon sizes again.

* Resize icons.

* Make spacing slightly smaller.

* Make icons larger so they're more similar to the old sizes.

* Remove padding to compensate for extra viewbox space.

* Try a smaller Twitter icon.

* Update snapchat icon.

* Resize social links in menu drawer to 44x44

* replace translation string to have the translation visible (Shopify#2869)

* B2B compare at price with price range (Shopify#2858)

* Add sale badge and price-range for volume-pricing

* Add compare_at price to PDP and Feat Prod.

* Change opacity to 100% for price per item.

* Update the logic

* Hide price per item for unavailable variants.

* Remove margin for dl.

* Refactoring

* Correct a mistake in liquid.

* Change the JS logic back for updating price per item

* Add compare at to prod card. Add style to compare at

* Assign font family to input fields.

* Update assets/base.css

Co-authored-by: Kai <KaichenWang@users.noreply.github.com>

* Use the theme's font style + weight in form elements.

---------

Co-authored-by: Sofia Matulis <sofiamatulis@users.noreply.github.com>
Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>

* Update 1 translation file (Shopify#3155)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#3157)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#3158)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 1 translation file (Shopify#3161)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Update 2 translation files (Shopify#3160)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Applied image shape and ratio to placeholder images (Shopify#2817)

added classes and styles to get image shape and image ratio working

added styling on portrait placeholders

aligned placeholder when in potrait mode

applying code review suggestions and removed image-ratio

* [Visual Display] Display accurate filter colors when high contrast mode is enabled (Shopify#3165)

* Improved country selectors (Shopify#3175)

Original PR with review comments -> Shopify#3135

* Update inline quantity error styles. (Shopify#3150)

* Update 1 translation file (Shopify#3177)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Variant Picker] Update settings copy (Shopify#3173)

* Bring back the lighthouse-ci-action to v1 (Shopify#3181)

This will make sure new releases are automatically used.

Better for forks as well.

* Changed slider to work on tablet for multicolumn (Shopify#3176)

* Changed slider to work on tablet for multicolumn

* Adjusted to prevent early cutoff on tablet

* Adjusted Featured Collection placeholders to work with any number of desktop columns (Shopify#3182)

* Adjusted featured collection placeholders to work with any number of desktop columns

* [Variant Picker] Add swatch display type (Shopify#3180)

* [VariantPicker] Unify variant selects and radios under new component

* [VariantPicker] Add swatch settings

* [VariantPicker] Move styles to dedicated CSS file

* [Variant Picker] Update settings copy

* [VariantPicker] Add swatch component

* [VariantPicker] Add a swatch to selected dropdown option

* [Variant Picker] Update disabled state

* [Variant Picker] Swatch snippet

* [Variant Picker] Swatch input snippet

* [Variant Picker] Tweak swatch border colors

* Update swatch border (Shopify#3184)

* Update translations: merchant (Shopify#3178)

* Update 1 translation file

* Update 1 translation file

* Update 2 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* [Variant Picker] Ensure that swatches wrap correctly (Shopify#3185)

* Focus search on country selector open and fix iOS bug (Shopify#3183)

* Focus search on country selector open

* Set stacking context

* Prevent sticky header from hiding when country selector is open (Shopify#3188)

* change to 100% (Shopify#3190)

* [Variant Picker] Simplify swatch settings (Shopify#3189)

* [Variant Picker] Simplify swatch settings

* Update 7 translation files

* Update 12 translation files

* Update 1 translation file

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

* Escape filter label consistently (Shopify#3192)

* Update 1 translation file (Shopify#3202)

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>

---------

Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: Ludo <ludo.segura@shopify.com>
Co-authored-by: Patrick Racicot <patrick.racicot@shopify.com>
Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com>
Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>
Co-authored-by: Jason Addleman <jason.addleman@shopify.com>
Co-authored-by: Sofia Matulis <sofiamatulis@users.noreply.github.com>
Co-authored-by: Louisa Goncharenko <93098869+lougoncharenko@users.noreply.github.com>
Co-authored-by: Tyler Alsbury <60230011+tyleralsbury@users.noreply.github.com>
Co-authored-by: Kjell Reigstad <kjell@kjellr.com>
Co-authored-by: melissaperreault <melissa.perreault@shopify.com>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
Co-authored-by: Alex Ilea <6627543+alisterdev@users.noreply.github.com>
Co-authored-by: Abdulrahman Hamideh <abdulrahman.hamideh@shopify.com>
Co-authored-by: CP Clermont <cp.clermont@shopify.com>
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
@patrickracicot
[Facets] dynamic header (Shopify#3048)
076dc00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewetchen andrewetchen andrewetchen approved these changes

@jas7457 jas7457 jas7457 approved these changes

@sofiamatulis sofiamatulis Awaiting requested review from sofiamatulis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickracicot @jas7457 @andrewetchen