Allow TracePoint re-entry during DAP's evaluation #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the TracePoint conflict with Zeitwerk, which was reported in ruby#408
st0012
force-pushed
the
fix-dap-evaluation-with-zeitwerk
branch
from
e7d7993
to
505d415
Compare
vinistock
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the debugger's
TracePointconflicting withZeitwerk's, which was reported in ruby#408The solution is simply wrapping
tp_allow_reentrylikeThreadClient#frame_eval_coredoes.And since the change is also essential for triggering another breakpoint during a suspension, I used nested breakpoint call for test.
Closes https://github.com/Shopify/ruby-dev-exp-issues/issues/1022