Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirror:moved event #493

Merged
merged 1 commit into from
May 17, 2021
Merged

Add mirror:moved event #493

merged 1 commit into from
May 17, 2021

Conversation

bahung1221
Copy link
Contributor

Thank you for submitting a pull request! Please make sure you have read the contribution guidelines before proceeding.

This PR implements mirror:moved event

The mirror:moved event will be trigger when the mirror handler of mirror:move event was done.

This PR closes the following issues... (if applicable)

#492

Does this PR require the Docs to be updated?

Yes

Does this PR require new tests?

Yes

This branch been tested on:

Browsers:

  • Chrome version
  • Firefox version
  • Safari version
  • IE / Edge version
  • iOS Browser version
  • Android Browser version

@bahung1221
Copy link
Contributor Author

Hi @zjffun ,
Can you please help to review this PR when you have time?

Have a nice weekend, thanks a lot 🍻

Copy link
Contributor

@zjffun zjffun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zjffun
Copy link
Contributor

zjffun commented May 16, 2021

Hi @tsov , this pr is ready to merge. Could you please help us review it when you have free time? Thank you.

@tsov tsov merged commit 5ba1ac8 into Shopify:master May 17, 2021
@tsov
Copy link
Member

tsov commented May 17, 2021

If you prep a new release, I can publish it later today!

@zjffun
Copy link
Contributor

zjffun commented May 17, 2021

I can prep a new release with #480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants