Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(types): fix the types of sensors #499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(types): fix the types of sensors #499

wants to merge 1 commit into from

Conversation

zjffun
Copy link
Contributor

@zjffun zjffun commented Jul 15, 2021

Thank you for submitting a pull request! Please make sure you have read the contribution guidelines before proceeding.

This PR fixes the types of sensors.

This PR closes the following issues #498

Does this PR require the Docs to be updated?

No

Does this PR require new tests?

No

This branch been tested on... (click all that apply / add new items)

Browsers:

  • Chrome version
  • Firefox version
  • Safari version
  • IE / Edge version
  • iOS Browser version
  • Android Browser version

bahung1221
bahung1221 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@bahung1221 bahung1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🍺

@bahung1221
Copy link
Contributor

Hi @tsov ,
This PR is ready to merge.
BTW, the version v1.0.0-beta.13 (#480 ) wasn't released yet, please help to check it.

Thanks a lot 🍺

@zjffun zjffun added the ready-to-merge Pull requests that ready to merge label Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahung1221 bahung1221 bahung1221 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready-to-merge Pull requests that ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjffun @bahung1221