Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes rubygem build for arm64 #95

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fixes rubygem build for arm64 #95

merged 1 commit into from
Jan 10, 2022

Conversation

hellvinz
Copy link
Contributor

No description provided.

@hellvinz hellvinz requested a review from burke as a code owner December 26, 2021 23:01
@ghost ghost added the cla-needed label Dec 26, 2021
@hellvinz
Copy link
Contributor Author

@casperisfine

etiennebarrie
etiennebarrie approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@etiennebarrie etiennebarrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellvinz hellvinz changed the base branch from master to 1.0-rfc-ruby January 6, 2022 12:46
@hellvinz hellvinz changed the base branch from 1.0-rfc-ruby to master January 6, 2022 12:46
@casperisfine
Copy link
Contributor

The CLA bot is still broken, given the small change I'll take the responsability to merge anyway.

Thanks for the fix Vince!

@casperisfine casperisfine merged commit 5c7d714 into Shopify:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebarrie etiennebarrie etiennebarrie approved these changes

@burke burke Awaiting requested review from burke

Assignees
No one assigned
Labels
cla-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellvinz @casperisfine @etiennebarrie