Fixes a crash caused by the reanimated library object freeze #867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Reanimated 3.0 they added shareables.ts recursively freezing objects that can possibly share values and one of it is
windowCorrectionConfig
we mutate. If we use Reanimated.ScrollView insiderenserScrollComponent
props then we get the error that we cannot mutatewindowCorrectionConfig.applyToInitialOffset
.To get around this issue, we don't mutate
windowCorrectionConfig
directly, instead we create a newwindowCorrectionConfig
object with the updated values and reassign it.Reproducing the case in Fixture would have needed to update Reanimated and React-Native which was not easily doable with the time we had.
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Checklist