skipping replication.GenericEvent #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-mysql don't parse those events, so we can't handle this event. This should fix the binlog_streamer panic Shopify#79.
shuhaowu
reviewed
Nov 20, 2018
There was a problem hiding this comment.
Do you know what events are being put into GenericEvent? I looked at the go-mysql code and it's just a default branch in a switch.
Given that we've successfully ran Ghostferry for sometime, this PR is likely OK. Documenting the unparsed events in here or in the comments (with a link to this thread) maybe helpful.
binlog_streamer.go
Outdated
| @@ -165,6 +165,10 @@ func (s *BinlogStreamer) Run() { | |||
| // This event can tell us about table structure change which means | |||
| // the cached schemas of the tables would be invalidated. | |||
| // TODO: investigate using this to allow for migrations to occur. | |||
| case *replication.GenericEvent: | |||
| // go-mysql don't parse this event, it use GenericEvent instead, | |||
There was a problem hiding this comment.
"go-mysql don't parse all events and unparsed events are denoted with empty GenericEvent structs"
hkdsun
approved these changes
Jan 9, 2019
shuhaowu
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-mysql doesn't parse those events, so we can't handle this event.
This should fix the binlog_streamer panic #79.