Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for using Remove on nil value. #20

Closed
wants to merge 2 commits into from
Closed

Add regression test for using Remove on nil value. #20

wants to merge 2 commits into from

Conversation

aybabtme
Copy link
Contributor

cc: @fbogsany

fbogsany
fbogsany reviewed Mar 13, 2014
View reviewed changes
regression_test.go
package lua_test

import (
"github.com/Shopify/go-lua"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the import

@aybabtme
Copy link
Contributor Author

I took a stab at fixing it, however it broke things in the other tests and I understood that I don't understand enough how indexToValue works. Seems some other functions expect indexToValue to return nil and carry on on those cases.

@aybabtme aybabtme mentioned this pull request Mar 13, 2014
Closed
@fbogsany
Copy link
Member

Fixed in 73092c8

@fbogsany fbogsany closed this Mar 15, 2014
@aybabtme
Copy link
Contributor Author

:win:

@fbogsany fbogsany deleted the regression branch February 26, 2015 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aybabtme @fbogsany