Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow graphql 2.0, add it to the build #151

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

rmosolgo
Copy link
Contributor

@rmosolgo rmosolgo commented Feb 9, 2022

I'm not sure how y'all actually want to use this version parameter, but I noticed it prevents GraphQL-Ruby 2.0. I added that new version to the build to double-check that it still worked, and while I was there, also bumped the top ruby version. Feel free to take any of this that you like, or let me know if there's anything I can change to make it more helpful!

@swalkinshaw
Copy link
Contributor

Makes sense. This was just a conservative guess initially I think.

@swalkinshaw swalkinshaw merged commit 5208953 into Shopify:master Feb 9, 2022
@dafeiner
Copy link

Hi @swalkinshaw - when is this change going to get folded into a new release? v0.5.0 still depends on a version < 2

@shopify-shipit shopify-shipit bot temporarily deployed to rubygems February 25, 2022 20:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants