-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosign container and binaries #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see the following in the logs: ``` error during command execution: signing /home/runner/work/hansel/hansel/dist/hansel_darwin_amd64_v1/hansel: getting key from Fulcio: verifying SCT: creating cached local store: resource temporarily unavailabl ``` Theories from "local store" is that is a conflict/race that limited parallelism will fix. Alternatively, could be a server-side throttle that limited paralellism may fix. This is probably the last stop before giving up on blob signing and just trying to get container signing working.
This reverts commit 2c69ad0.
This reverts commit f28d3a6.
This reverts commit 2170bde.
thepwagner
requested review from
a team and
cdenyar
and removed request for
a team
June 24, 2022 14:09
Owen-Cummings
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This shipped in https://github.com/Shopify/hansel/releases/tag/v0.0.4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cosign+fulcio to sign the containers and binaries generated from the release process.
I've tested this in https://github.com/thepwagner/hansel , and this PR include the "receipts" from that experimentation. I'll be sure to squash.
You can verify the container:
.[].critical.image."docker-manifest-digest"
should match what you see at https://github.com/users/thepwagner/packages/container/hansel/26575582?tag=0.0.9'.[].optional | .Issuer, .Subject'
should indicate this certificate was granted to the GitHub Actions workflow that produced the image.You can verify the blobs:
cosign verify-blob
stateVerified OK
for the signature.O = sigstore.dev, CN = sigstore-intermediate