Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .has() method to the hydrogen session class #1044

Merged
merged 1 commit into from
Jun 26, 2023
Merged

add .has() method to the hydrogen session class #1044

merged 1 commit into from
Jun 26, 2023

Conversation

juanpprieto
Copy link
Contributor

WHY are these changes introduced?

.has() is a standard method of session.

HOW to test your changes?

Screenshot 2023-06-26 at 1 01 37 AM

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@juanpprieto juanpprieto requested a review from a team June 26, 2023 13:34
@juanpprieto juanpprieto merged commit 2d63d86 into 2023-04 Jun 26, 2023
@juanpprieto juanpprieto deleted the juanpprieto/add-has-method-to-session-class branch June 26, 2023 16:05
juanpprieto added a commit that referenced this pull request Jul 10, 2023
@juanpprieto
add .has() method to the hydrogen session class (#1044)
aae79d6
FrcPpe pushed a commit to FrcPpe/hydrogen that referenced this pull request Aug 13, 2023
@juanpprieto @FrcPpe
add .has() method to the hydrogen session class (Shopify#1044)
364f055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blittle blittle blittle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanpprieto @blittle