Fix souremaps to be included on deployments from the CLI #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgodson
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
It's not ideal that we run a build command here when there's already a dedicated build command... I guess unless we force a build before running deploy there's not much getting around that though. I wonder if deploy should support all/a subset of the build flags too?
This was referenced Jan 10, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We want to generate sourcemaps even for deployments via the CLI.
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist