New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update toDateString() to toLocaleDateString() #1722

Closed

daikisuyama wants to merge 1 commit into Shopify:main from daikisuyama:main

+13 −13

daikisuyama commented Feb 2, 2024 •

edited

Loading

WHY are these changes introduced?

Because the date displayed did not reflect locale.

WHAT is this pull request doing?

Just grep and update all toDateString() to toLocaleDateString()

HOW to test your changes?

You can easily check these from UI.

Checklist

I've read the Contributing Guidelines
I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've added a changeset if this PR contains user-facing or noteworthy changes
I've added tests to cover my changes
I've added or updated the documentation


          Update toDateString() to toLocaleDateString()

a8b016e

github-actions bot added the cla-needed label

daikisuyama closed this

daikisuyama reopened this

daikisuyama closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels