Adding an example for B2B #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
michenly
force-pushed
the
df/b2b-example
branch
from
7d5477f
to
ebefc4f
Compare
michenly
reviewed
Mar 28, 2024
michenly
reviewed
Mar 28, 2024
michenly
reviewed
Mar 28, 2024
michenly
reviewed
Mar 28, 2024
| new Date( | ||
| new Date().getTime() + (expires_in! - 120) * 1000, | ||
| ).getTime() + '', | ||
| new Date(new Date().getTime() + (expires_in - 120) * 1000).getTime() + |
There was a problem hiding this comment.
I removed the ! in this line.
dustinfirman
force-pushed
the
df/b2b-example
branch
from
452b690
to
b026930
Compare
This comment has been minimized.
This comment has been minimized.
juanpprieto
reviewed
Apr 4, 2024
dustinfirman
force-pushed
the
df/b2b-example
branch
from
2739668
to
d1a15c1
Compare
dustinfirman
force-pushed
the
df/b2b-example
branch
2 times, most recently
from
a88b87c
to
994ba78
Compare
dustinfirman
force-pushed
the
df/b2b-example
branch
from
cdce061
to
301d0e0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // if the url is internal, we strip the domain | ||
| const url = | ||
| item.url.includes('myshopify.com') || |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization
dustinfirman
force-pushed
the
df/b2b-example
branch
from
301d0e0
to
cdce061
Compare
wizardlyhel
previously requested changes
May 3, 2024
|
Got error in logged out state on the product page. Looks like just need to avoid destructuring when buyer doesn't exists. 
|
|
I also did some clean up on the |
dustinfirman
force-pushed
the
df/b2b-example
branch
from
53e99a1
to
eade5ee
Compare
working queries contextualized queries quantity and volume prices added header selector login redirect handle single location buyers convert location selector to form convert location dropdown to form update input type
move token exchange and add get set buyer move set buyer into customerAccount remove buyer expire remove locations and use cart instead automatically get buyeridentity from customerAccount
michenly
requested changes
May 7, 2024
There was a problem hiding this comment.
👏 👏 👏
Overall really well done and it looks great and works well!
I made a bunch of suggestions on the PR but the really important ones that's must fix are:
- missing
maximumrule from Cart.tsx - 🐛 quantity increment rule in Cart.tsx
- 🐛 updating Cart after logout
- do not cache storefront query with customer account token
- add a changeset for @shopify/hydrogen unstable features
michenly
reviewed
May 7, 2024
michenly
approved these changes
May 7, 2024
dustinfirman
dismissed
wizardlyhel’s stale review
Addressed the comments and got approval from @michenly
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an example for B2B, along with an update to the customer account client to support a storefront customer access token via the storefrontCustomerAccessTokenCreate mutation.
WHY are these changes introduced?
Resolves #1677
Hydrogen utilities method for b2b merchant to use.
here is the flow for a typical B2B Hydrogen store
customerAccountAccessToken, and exchange it forstorefrontCustomerAccountAccessTokenimmediately after authorizeWHAT is this pull request doing?
Encapsulating common tasks into hydrogen utilities
storefrontclient, ifb2boption is true, a query variable will get automatically created by usingbuyer = customerAccount.UNSTABLE_getBuyer()customerAccount, at the end ofauthorize(), do a token exchange and saved to session.customerAccount, exposeUNSTABLE_setBuyerandUNSTABLE_getBuyerto get and set Buyer on the session. the getter will do a login + expire check, if customerAccessToken is expired and need refresh, the storefrontCustomerAccessToken will automatically follow as wellcreateCartHandler, when we create the cart, the mutation will be run with buyerIdentity coming fromcustomerAccount.UNSTABLE_getBuyer()directlyHOW to test your changes?
Post-merge steps
Checklist