Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make h2 setup vite command stable #1915

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Make h2 setup vite command stable #1915

merged 11 commits into from
Apr 4, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Mar 27, 2024

WHY are these changes introduced?

The h2 setup vite command was experimental and it had a few issues. This PR makes it more robust and removes the "experimental" confirmation prompt.

WHAT is this pull request doing?

It now covers most of the steps in the Remix upgrade guide: https://remix.run/docs/en/main/future/vite

  • Throw if project is already using Vite
  • Remove deprecated Remix css-bundle dependency
  • Support CSS Modules
  • Support Vanilla Extract
  • Improve edge cases for Tailwind support
  • Move some remix.config.js properties to vite.config.js (appDirectory, routes, ignoredRouteFiles, future)
  • Notify about MDX support to set it up manually if it was used

HOW to test your changes?

h2 setup vite in project variations with vanilla-extract, modules, changes in remix.config.js etc.

@frandiox frandiox requested a review from a team March 27, 2024 19:04
Copy link
Contributor

shopify bot commented Mar 27, 2024

Oxygen deployed a preview of your fd-improve-setup-vite branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
vite ✅ Successful (Logs) Preview deployment Inspect deployment March 28, 202411:55 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment March 28, 202411:55 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment March 28, 202411:55 AM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment March 28, 202411:55 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment March 28, 202411:55 AM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment March 28, 202411:55 AM

Learn more about Hydrogen's GitHub integration.

This comment has been minimized.

@frandiox frandiox merged commit 99d72f7 into main Apr 4, 2024
13 checks passed
@frandiox frandiox deleted the fd-improve-setup-vite branch April 4, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants