Move Vite plugins to their new home #1935
Conversation
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
…tead of remix-oxygen
* Use Remix presets for virtual routes * Pin oxygen-cli dependency to fix installation * Avoid adding virtual routes in build * Wrap virtual routes in virtual root * Omit user root when rendering virtual routes * Move buildDirectory to preset and use it in projects * Update tests
|
I wonder if this is a first load error kinda thing. Happens right after I tried:
both generated this error on first load 
|
@wizardlyhel This is a bug in Remix that we fixed already: remix-run/remix#9194 Should be out in the next release but maybe I should silence this error in the meantime 🤔 -- It's only related to critical CSS for the subrequest profiler, so not very important. Hidden in 48f54be |
|
I'm reverting #1939 here due to errors in subdependencies. |
This PR stabilizes our Vite plugins and moves them to their respective packages.
Originally, we were adding DX utilities (subrequest profiler, graphiql, etc.) directly in our CLI because the classic Remix compiler did not offer much flexibility.
When we released the experimental Vite integration, these utilities were adjusted to work with Vite but were still all in the CLI for the sake of velocity.
In this PR, these features are now migrated to the Vite plugins so that we stop using most of our hacky code around Remix to make them work.
Changes:
hydrogen()plugin to@shopify/hydrogen/vite. Vite is an optional peer dependency of this package now.oxygen()plugin to@shopify/mini-oxygen/vite, which now contains all the workerd integration.@shopify/remix-oxygenfor/subrequest-profiler. The new code is directly added in the Hydrogen plugin.