-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydrogen CLI's env push
command is released
#1946
Conversation
- Hydrogen CLI's `env push` command is the counterpart for the `env pull` command. It is used to push environment variables found in the `.env` file to Admin. Refer to [docs](https://shopify.dev/docs/custom-storefronts/hydrogen/cli) for full usage details. - Updated internal libraries for parsing `.env` file.
"@shopify/hydrogen-codegen": "^0.2.2", | ||
"@shopify/oxygen-cli": "4.3.6", | ||
"@shopify/oxygen-cli": "~4.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wizardlyhel Could i allow patch updates to the oxygen-cli? Or should i keep the version locked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine 👍
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I've fixed these issues:
- Update our CLI dependencies in our templates to be in sync with the new cli-kit version
- Fix unit test error related to changes in cli-kit
- Fixed package-lock.json duplicating dependencies in some workspace packages
- Updated the Oclif manifest with Fix command order in Oclif manifest #1949 to avoid conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benwolfram you probably just need to build the other packages first. Try |
@frandiox I am getting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 💯 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got tophat going and looks good!
06154dc
to
6f81191
Compare
WHY are these changes introduced?
env push
command for the Hydrogen CLI.env file
WHAT is this pull request doing?
env push
command is the counterpart for theenv pull
command. It is used to push environment variables found in the.env
file to Admin. Refer to docs for full usage details..env
file.HOW to test your changes?
npm ci && cd packages/cli && npm run build
npx shopify hydrogen env push --path=/path/to/repo (if you don't have a repo, create it using the
npx shopify hydrogen init` command)Post-merge steps
Checklist