Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let missing routes match catch-all routes #1948

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

elia
Copy link
Contributor

@elia elia commented Apr 8, 2024

WHY are these changes introduced?

I got a message for missing routes for the collection route, but I just renamed it to catch collection handles that included slashes: routes/collections.$handle.tsroutes/collections.$.ts.

The new route will still cover for requests falling under the original one.

WHAT is this pull request doing?

This change will make the missing-routes library recognize routes using $.

HOW to test your changes?

Rename the collection route to collections.$.ts and run shopify hydrogen check routes.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@blittle blittle marked this pull request as ready for review April 11, 2024 14:06
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good!

@blittle blittle merged commit f0c58e0 into Shopify:main Apr 11, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants