Let missing routes match catch-all routes #1948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
I got a message for missing routes for the collection route, but I just renamed it to catch collection handles that included slashes:
routes/collections.$handle.ts
→routes/collections.$.ts
.The new route will still cover for requests falling under the original one.
WHAT is this pull request doing?
This change will make the missing-routes library recognize routes using
$
.HOW to test your changes?
Rename the collection route to
collections.$.ts
and runshopify hydrogen check routes
.Checklist