Refactor: move classic compiler code #1999
Conversation
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
|
I'm afraid this is related to the new global CLI 🤔 |
|
Yeah, this is happening as well in I'll try to find a workaround in another branch -- #2075 |
| const {runClassicCompilerBuild} = await import( | ||
| '../../lib/classic-compiler/build.js' | ||
| ); |
There was a problem hiding this comment.
Is the reason to only lazy load the classic compiler because we'll eventually deprecate and remove the classic compiler logic? If so, why do we not lazy load the other classic functionality for dev, deploy, and preview?
There was a problem hiding this comment.
No, this was probably something I didn't refactor. We are already loading optional dependencies like @remix-run/dev dynamically so we can import these functions statically everywhere.
| @@ -564,7 +564,7 @@ Continue?`.value, | |||
| outputContent`${colors.whiteBright('Building project...')}`.value, | |||
| ); | |||
|
|
|||
| const build = isClassicCompiler ? runBuild : runViteBuild; | |||
| const build = isClassicCompiler ? runClassicCompilerBuild : runBuild; | |||
There was a problem hiding this comment.
Worth lazy loading the classic compiler here too?
|
We detected some changes in |
dev-viteanddevcommandsbuild-viteandbuildcommandslibinit.test.tsin different filesMinor fixes to--quickstartCleanup code related to the--stylingflag🎩 : Nothing should change in behavior, except for the minor fixes.