Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add protocol to shopify domain when call using the provider #2079

Merged
merged 2 commits into from
May 6, 2024

Conversation

michenly
Copy link
Contributor

@michenly michenly commented May 2, 2024

WHY are these changes introduced?

Fixes #2063

WHAT is this pull request doing?

Ensure when using <ShopifyProvider />'s getShopifyDomain method. It will always included https protocol.

HOW to test your changes?

Set up <ShopifyProvider /> with storeDomain prop without https protocol. Call getShopifyDomain() and see the method return the same domain with https.

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@michenly michenly self-assigned this May 2, 2024
@michenly michenly requested a review from a team May 2, 2024 14:54
Co-authored-by: Bret Little <bret.little@shopify.com>
Copy link
Contributor

shopify bot commented May 6, 2024

Oxygen deployed a preview of your mc-add-protocal-to-shopify-domain branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment May 6, 2024 3:05 PM

Learn more about Hydrogen's GitHub integration.

@michenly michenly merged commit 081e149 into main May 6, 2024
13 checks passed
@michenly michenly deleted the mc-add-protocal-to-shopify-domain branch May 6, 2024 15:07
@hsdonkin
Copy link

hsdonkin commented May 6, 2024

Thanks for fixing this!

@michenly
Copy link
Contributor Author

michenly commented May 6, 2024

@hsdonkin no problem. It will be included in the next release which should happen within 1-2 weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getStorefrontApiUrl() is missing https protocol
3 participants