Handle promise rejection in upgrade notification #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
frandiox
commented
May 8, 2024
Comment on lines
+1094
to
+1100
| } catch (error) { | ||
| const abortError = error as AbortError; | ||
| renderWarning({ | ||
| headline: abortError.message, | ||
| body: abortError.tryMessage ?? undefined, | ||
| }); | ||
| } |
There was a problem hiding this comment.
This is the only relevant part of the diff.
wizardlyhel
approved these changes
May 8, 2024
michenly
approved these changes
May 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the upgrade notification was showing unhandled promise rejections. This catches the errors and print them as warnings.
Before:
After: