Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite bundle analyzer #2138

Merged
merged 18 commits into from
Jul 8, 2024
Merged

Vite bundle analyzer #2138

merged 18 commits into from
Jul 8, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented May 22, 2024 •
edited
Loading

Start generating a metafile in Vite similar to the one in ESBuild so that we can reuse the ESBuild bundle analyzer logic we had for classic projects.

image image image

🎩 :

  • Build templates/skeleton and examples/classic-remix and compare the results.

@shopify Shopify
Copy link
Contributor

shopify bot commented May 22, 2024 •
edited
Loading

Oxygen deployed a preview of your fd-vite-bundle-analyzer branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment June 11, 2024 4:42 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 202412:19 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 202412:19 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 202412:19 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 202412:19 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 202412:19 PM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox marked this pull request as ready for review June 11, 2024 04:23
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@frandiox frandiox requested review from blittle and a team June 11, 2024 04:26
@frandiox frandiox changed the title WIP Vite bundle analyzer Vite bundle analyzer Jun 11, 2024
@frandiox frandiox removed the request for review from blittle June 14, 2024 04:25
wizardlyhel
wizardlyhel approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@frandiox frandiox merged commit f306537 into main Jul 8, 2024
13 checks passed
@frandiox frandiox deleted the fd-vite-bundle-analyzer branch July 8, 2024 08:13
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizardlyhel wizardlyhel wizardlyhel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frandiox @wizardlyhel