Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix article format & invalid blogs url format #2151

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

michenly
Copy link
Contributor

@michenly michenly commented May 24, 2024

WHY are these changes introduced?

Article url incorrect:

  1. /blog does not exist. Only /blogs
  2. The blog handle is missing from the url

Screenshot 2024-05-24 at 4 51 43 PM

Article format incorrect

Screenshot 2024-05-24 at 4 51 57 PM

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@michenly michenly self-assigned this May 24, 2024
Copy link
Contributor

shopify bot commented May 24, 2024

Oxygen deployed a preview of your fix-search-for-blogs branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 27, 2024 5:12 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 27, 2024 5:12 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 27, 2024 5:12 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 27, 2024 5:12 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment May 27, 2024 5:12 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 27, 2024 5:12 PM

Learn more about Hydrogen's GitHub integration.

@michenly michenly requested a review from a team May 24, 2024 20:53
@michenly michenly force-pushed the fix-search-for-blogs branch 8 times, most recently from db23e24 to 2d6dbc6 Compare May 25, 2024 01:08
@michenly michenly requested review from frandiox and a team May 27, 2024 17:08
@michenly michenly merged commit c31c655 into main May 27, 2024
12 checks passed
@michenly michenly deleted the fix-search-for-blogs branch May 27, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants