Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new lines in <RichText> component #2198

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jun 5, 2024

Fixes this usecase: #2144 (comment)

It now creates a React fragment with the string and a <br> for each new line in a text node.

@frandiox frandiox requested review from blittle and a team June 5, 2024 09:57
Copy link
Contributor

github-actions bot commented Jun 5, 2024

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

shopify bot commented Jun 5, 2024

Oxygen deployed a preview of your fd-richtext-newlines branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment June 5, 2024 2:14 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment June 5, 2024 2:14 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment June 5, 2024 2:14 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment June 5, 2024 2:14 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment June 5, 2024 2:14 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment June 5, 2024 2:14 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test. Thx for fixing it!

@blittle blittle merged commit 9539264 into main Jun 5, 2024
13 checks passed
@blittle blittle deleted the fd-richtext-newlines branch June 5, 2024 14:16
@SalimDigitalMarketing

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants