Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the docs #2355

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix the docs #2355

merged 1 commit into from
Jul 23, 2024

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Jul 22, 2024

We need to make sure to update @shopify/generate-docs to the latest with each release. Separately, when generating docs, we need to make sure it actually succeeds in the compilation. When it doesn't, it can leave a ton of JS files that shouldn't be in VC. I think this is why there are duplicate nodes on the docs site right now:

image

Copy link
Contributor

shopify bot commented Jul 22, 2024

Oxygen deployed a preview of your bl-fix-docs branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 22, 2024 8:27 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 22, 2024 8:27 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 22, 2024 8:27 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 22, 2024 8:27 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 22, 2024 8:27 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 22, 2024 8:27 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

@michenly michenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing it!

@blittle blittle merged commit 25ab903 into main Jul 23, 2024
13 checks passed
@blittle blittle deleted the bl-fix-docs branch July 23, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants