Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pages route #56

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add pages route #56

merged 1 commit into from
Oct 4, 2022

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Oct 4, 2022

Closes #4

@caution-tape-bot
Copy link

We noticed that this PR either modifies or introduces usage of the dangerouslySetInnerHTML attribute, which can cause cross-site scripting (XSS) vulnerabilities when user controlled values are passed in.
We recommend reviewing your code to ensure that this is what you intended to use and that there is not a safe alternative available.

Docs are available here.

If unavoidable, we reccomend using an HTML sanitizer like DOMPurify to sanitize content before
rendering it as HTML.

If you have any questions or are unsure about how to move forward with this, ping #help-appsec and we would
be happy to help you out! cc: @Shopify/xss-extermination-squad

View the source of this rule in Services DB

@frandiox frandiox merged commit b5bcb98 into main Oct 4, 2022
@frandiox frandiox deleted the fd-pages branch October 4, 2022 10:32
@frandiox frandiox mentioned this pull request Oct 4, 2022
1 task
remcolakens added a commit to remcolakens/hydrogen that referenced this pull request Jul 14, 2023
## Context

As a user I would like to have a native dropdown to make a selection of
the product variant

## Changes

Added new package `@code-internet-applications/select` for the monorepo
which contains the basic dropdown styling

## Screenshot


![select-styling](https://github.com/code-internet-applications/cbt-hydrogen/assets/2558163/79685b58-feec-4ed1-affb-11e7478d5221)

## Paperwork

[SCH-34](https://codeinternetapplications.atlassian.net/browse/SCH-34)

## Checklist

- [x] My code follows the style guidelines of this project
- [x] I've performed a self-review of my own code
- [x] I've added a changeset if this PR contains user-facing or
noteworthy changes
- [x] I've commented my code, particularly in hard-to-understand areas
- [x] I've made corresponding changes to the documentation
- [x] I've tested my code for breaking changes and added the
corresponding
      footer in this PR if needed


[SCH-34]:
https://codeinternetapplications.atlassian.net/browse/SCH-34?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
remcolakens added a commit to remcolakens/hydrogen that referenced this pull request Jul 14, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @code-internet-applications/aspect-ratio@0.1.0

### Minor Changes

-
[Shopify#63](https://github.com/code-internet-applications/cbt-hydrogen/pull/63)

[`65896a7`](https://github.com/code-internet-applications/cbt-hydrogen/commit/65896a76614c65c773824dba9fdf922275ab58d5)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-75: add
aspect
    ratio & image component

## @code-internet-applications/badge@0.2.0

### Minor Changes

-
[Shopify#64](https://github.com/code-internet-applications/cbt-hydrogen/pull/64)

[`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-27: add
product
    card

-
[Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58)

[`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added
new
    radio buttons to match with the CBT design

## @code-internet-applications/card@0.1.0

### Minor Changes

-
[Shopify#64](https://github.com/code-internet-applications/cbt-hydrogen/pull/64)

[`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-27: add
product
    card

## @code-internet-applications/container@0.1.0

### Minor Changes

-
[Shopify#62](https://github.com/code-internet-applications/cbt-hydrogen/pull/62)

[`e2cd2f6`](https://github.com/code-internet-applications/cbt-hydrogen/commit/e2cd2f6484d0dac9678dfa6d7e2ec675cf9863c3)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-103: add
    container component

## @code-internet-applications/label@0.2.0

### Minor Changes

-
[Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58)

[`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added
new
    radio buttons to match with the CBT design

## @code-internet-applications/price@0.1.0

### Minor Changes

-
[Shopify#64](https://github.com/code-internet-applications/cbt-hydrogen/pull/64)

[`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-27: add
product
    card

-
[Shopify#60](https://github.com/code-internet-applications/cbt-hydrogen/pull/60)

[`cc39edd`](https://github.com/code-internet-applications/cbt-hydrogen/commit/cc39eddee2edd03d03b9b930343e093141943a84)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-36: add
price
    styling

## @code-internet-applications/quantity-selector@0.1.0

### Minor Changes

-
[Shopify#61](https://github.com/code-internet-applications/cbt-hydrogen/pull/61)

[`fe3cc29`](https://github.com/code-internet-applications/cbt-hydrogen/commit/fe3cc29e36b7dac027411905fc67e0a7c92d0143)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-35: add
quantity
    selector

## @code-internet-applications/radio@0.1.0

### Minor Changes

-
[Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58)

[`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added
new
    radio buttons to match with the CBT design

## @code-internet-applications/react@0.4.0

### Minor Changes

-
[Shopify#64](https://github.com/code-internet-applications/cbt-hydrogen/pull/64)

[`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-27: add
product
    card

-
[Shopify#62](https://github.com/code-internet-applications/cbt-hydrogen/pull/62)

[`e2cd2f6`](https://github.com/code-internet-applications/cbt-hydrogen/commit/e2cd2f6484d0dac9678dfa6d7e2ec675cf9863c3)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-103: add
    container component

-
[Shopify#61](https://github.com/code-internet-applications/cbt-hydrogen/pull/61)

[`fe3cc29`](https://github.com/code-internet-applications/cbt-hydrogen/commit/fe3cc29e36b7dac027411905fc67e0a7c92d0143)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-35: add
quantity
    selector

-
[Shopify#60](https://github.com/code-internet-applications/cbt-hydrogen/pull/60)

[`cc39edd`](https://github.com/code-internet-applications/cbt-hydrogen/commit/cc39eddee2edd03d03b9b930343e093141943a84)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-36: add
price
    styling

-
[Shopify#63](https://github.com/code-internet-applications/cbt-hydrogen/pull/63)

[`65896a7`](https://github.com/code-internet-applications/cbt-hydrogen/commit/65896a76614c65c773824dba9fdf922275ab58d5)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-75: add
aspect
    ratio & image component

-
[Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58)

[`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added
new
    radio buttons to match with the CBT design

### Patch Changes

-   Updated dependencies

\[[`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da),

[`e2cd2f6`](https://github.com/code-internet-applications/cbt-hydrogen/commit/e2cd2f6484d0dac9678dfa6d7e2ec675cf9863c3),

[`fe3cc29`](https://github.com/code-internet-applications/cbt-hydrogen/commit/fe3cc29e36b7dac027411905fc67e0a7c92d0143),

[`cc39edd`](https://github.com/code-internet-applications/cbt-hydrogen/commit/cc39eddee2edd03d03b9b930343e093141943a84),

[`65896a7`](https://github.com/code-internet-applications/cbt-hydrogen/commit/65896a76614c65c773824dba9fdf922275ab58d5),

[`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391),

[`c33327a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/c33327a5e3d6107517dff5507c220ed1c9feb960)]:
    -   @code-internet-applications/badge@0.2.0
    -   @code-internet-applications/price@0.1.0
    -   @code-internet-applications/card@0.1.0
    -   @code-internet-applications/container@0.1.0
    -   @code-internet-applications/quantity-selector@0.1.0
    -   @code-internet-applications/aspect-ratio@0.1.0
    -   @code-internet-applications/select@0.1.0
    -   @code-internet-applications/label@0.2.0
    -   @code-internet-applications/radio@0.1.0

## @code-internet-applications/select@0.1.0

### Minor Changes

-
[Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58)

[`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added
new
    radio buttons to match with the CBT design

-
[Shopify#56](https://github.com/code-internet-applications/cbt-hydrogen/pull/56)

[`c33327a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/c33327a5e3d6107517dff5507c220ed1c9feb960)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: add new
    component for the Select styling

## @code-internet-applications/tailwind-config@0.4.0

### Minor Changes

-
[Shopify#62](https://github.com/code-internet-applications/cbt-hydrogen/pull/62)

[`e2cd2f6`](https://github.com/code-internet-applications/cbt-hydrogen/commit/e2cd2f6484d0dac9678dfa6d7e2ec675cf9863c3)
Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-103: add
    container component

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages (/pages/*)
1 participant