Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Remix HMR #652

Closed
wants to merge 3 commits into from
Closed

Support Remix HMR #652

wants to merge 3 commits into from

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Mar 7, 2023

Related: #582

I'm trying to understand what we need to support Remix HMR in MiniOxygen. Not sure if we should merge this since part of the Remix internals is currently copied (live-reload.ts file) and it could break in Remix@0.15.

Requirements:

  1. Ensure it's running Remix 0.14
  2. Add <LiveReload /> to root.tsx
  3. Add future: {unstable_dev: true} to remix.config.js

A way to test this is writing something in the search input at the top, then modify anything in the page and save. The typed text should not be removed when updating.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@frandiox frandiox requested review from a team and removed request for a team March 7, 2023 10:58
@frandiox frandiox marked this pull request as draft March 8, 2023 00:14
@frehner
Copy link
Contributor

frehner commented Apr 26, 2023

Closing, but if you feel like this is still applicable please reopen and resolve conflicts! 👍

@frehner frehner closed this Apr 26, 2023
@HumidBrains
Copy link

@frehner Why is this issue closed, and without any explanation? Isn't HMR becoming available to Hydrogen or have I missed out on some vital info? Frankly, the dev experience is unbearable with full page reloads taking what feels like an eternity every time.

@frandiox
Copy link
Contributor Author

HMR support will come soon but this PR is outdated. We had to wait until HMR in Remix became stable (it just did) because otherwise it would break often in Hydrogen.

@frandiox frandiox mentioned this pull request Aug 4, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants