-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the raw product returned from the Storefront API to also return from useProduct #735
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
'@shopify/hydrogen-react': patch | ||
--- | ||
|
||
Add the raw product returned from the Storefront API to also return from `useProduct()`: | ||
|
||
```ts | ||
function SomeComponent() { | ||
const {product} = useProduct(); | ||
|
||
return ( | ||
<div> | ||
<h2>{product.title}</h2> | ||
<h3>{product.description}</h3> | ||
</div> | ||
); | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,24 @@ | ||
import {ProductProvider} from '@shopify/hydrogen-react'; | ||
import {ProductProvider, useProduct} from '@shopify/hydrogen-react'; | ||
|
||
export function Product({product}) { | ||
return ( | ||
<ProductProvider data={product} initialVariantId="some-id"> | ||
{/* Your JSX */} | ||
<UsingProduct /> | ||
</ProductProvider> | ||
); | ||
} | ||
|
||
function UsingProduct() { | ||
const {product, variants, setSelectedVariant} = useProduct(); | ||
return ( | ||
<> | ||
<h1>{product?.title}</h1> | ||
{variants?.map((variant) => { | ||
<button onClick={() => setSelectedVariant(variant)} key={variant?.id}> | ||
{variant?.title} | ||
</button>; | ||
})} | ||
; | ||
</> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,25 @@ | ||
import {ProductProvider} from '@shopify/hydrogen-react'; | ||
import {ProductProvider, useProduct} from '@shopify/hydrogen-react'; | ||
import type {Product} from '@shopify/hydrogen-react/storefront-api-types'; | ||
|
||
export function Product({product}: {product: Product}) { | ||
return ( | ||
<ProductProvider data={product} initialVariantId="some-id"> | ||
{/* Your JSX */} | ||
<UsingProduct /> | ||
</ProductProvider> | ||
); | ||
} | ||
|
||
function UsingProduct() { | ||
const {product, variants, setSelectedVariant} = useProduct(); | ||
return ( | ||
<> | ||
<h1>{product?.title}</h1> | ||
{variants?.map((variant) => { | ||
<button onClick={() => setSelectedVariant(variant)} key={variant?.id}> | ||
{variant?.title} | ||
</button>; | ||
})} | ||
; | ||
</> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import {ReferenceEntityTemplateSchema} from '@shopify/generate-docs'; | ||
|
||
const data: ReferenceEntityTemplateSchema = { | ||
name: 'useProduct', | ||
category: 'hooks', | ||
isVisualComponent: false, | ||
related: [ | ||
{ | ||
name: 'ProductProvider', | ||
type: 'component', | ||
url: '/api/hydrogen-react/components/productprovider', | ||
}, | ||
], | ||
description: | ||
'Provides access to the product value passed to `<ProductProvider />`. It also includes properties for selecting product variants, options, and selling plans.', | ||
type: 'hook', | ||
defaultExample: { | ||
description: 'I am the default example', | ||
codeblock: { | ||
tabs: [ | ||
{ | ||
title: 'JavaScript', | ||
code: './ProductProvider.example.jsx', | ||
language: 'jsx', | ||
}, | ||
{ | ||
title: 'TypeScript', | ||
code: './ProductProvider.example.tsx', | ||
language: 'tsx', | ||
}, | ||
], | ||
title: 'Example code', | ||
}, | ||
}, | ||
definitions: [ | ||
{ | ||
title: 'Props', | ||
type: 'UseProductGeneratedType', | ||
description: | ||
'`useProduct` must be a descendent of the `<ProductProvider />` component.', | ||
}, | ||
], | ||
}; | ||
|
||
export default data; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that this won't be a problem, changing the memo dependency array. I'd think if the product changes, so would these arrays. Also if these arrays change, so would the wrapping product.