Add description about deployment phases #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
reviewed
Oct 7, 2019
| Deploying PersistentVolumeClaim/hello-cloud-redis (timeout: 300s) | ||
| Successfully deployed in 3.3s: PersistentVolumeClaim/hello-cloud-redis | ||
|
|
||
| Deploying Role/role (timeout: 300s) |
There was a problem hiding this comment.
300 is strange here.
module KubernetesDeploy
class Role < KubernetesResource
TIMEOUT = 30.seconds
There was a problem hiding this comment.
It's reproducible though. I'll try to debug this and, if needed, will fix on a separate PR.
RyanBrushett
reviewed
Oct 7, 2019
RyanBrushett
approved these changes
Oct 9, 2019
dirceu
force-pushed
the
add-walkthrough
branch
from
33a30ce
to
21648ef
Compare
douglas
approved these changes
Oct 10, 2019
dturn
approved these changes
Oct 10, 2019
dirceu
force-pushed
the
add-walkthrough
branch
from
6082bef
to
47a9704
Compare
|
Closes #105. |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
As part of #105, we want to add a step by step walkthrough of a
krane deployrun.How is this accomplished?
I picked a reproducible example from our test suite and used that to explain the different phases.