Stop core service from being deployed a priority resource #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spoke too soon, seems like a couple tests are failing, will 👀 |
added 2 commits
July 23, 2020 15:41
|
Failing tests are now the same ones as master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Creating a custom resource def that has the same
kindtype as a core type can cause deploying a core type to be considered a priority resource.How is this accomplished?
We should also consider
groupwhen deciding if resources are crd's. The predeploy_sequence array list was converted to a hash keyed by kindWhat could go wrong?
Could this mess up priority decision logic for other resources? Tests don't seem to be broken for crs so 👍 sign