Allow raw tag to be used with whitespace control #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanahsmith
reviewed
Feb 1, 2023
| @@ -12,6 +12,7 @@ def test_tag_in_raw | |||
|
|
|||
| def test_output_in_raw | |||
| assert_template_result('{{ test }}', '{% raw %}{{ test }}{% endraw %}') | |||
| assert_template_result('{{ test }}', '{%- raw -%}{{ test }}{%- endraw -%}') | |||
There was a problem hiding this comment.
This doesn't actually test the effect of the whitespace control characters. We don't want to support whitespace control characters if they don't actually strip text. E.g. I would expect
Suggested change
| assert_template_result('{{ test }}', '{%- raw -%}{{ test }}{%- endraw -%}') | |
| assert_template_result('>{{ test }}<', '> {%- raw -%} {{ test }} {%- endraw -%} <') |
dylanahsmith
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
Currently using the
rawtag with whitespace control is unsupported, as it can be seen by removing my changes but keeping the new test.how?
Just allow
#{WhitespaceControl}to be there in the ending tag forraw.