fix variable lookup parse timing out with missing closing bracket #1684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR #1680 has introduced a bug that causes
VariableLookup#initialize
to time out.This happened when the
VariableLookup
's markup had a missing closing bracket and a very long string.The regex is taking a long time to execute because the non-capturing group
(?:[^\[^]+...
recursively re-searches/backtraces the input with different lengths.The non-capturing group match will look like this throughout the search:
Solution
We can use the atomic group feature in regex to prevent regex from dividing the non-bracket characters, and early end the search.