Do not raise when variable is defined #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables which are defined but have a nil value should not raise. See #749
|
Can you fix the style violations? |
|
Fixed the ones that I introduced. The others should be fixed in another PR, I guess. |
|
ugh sorry, I wasn't aware that things are failing on master too |
|
Hm it's not failing for me locally. Not sure why it's failing on travis. |
.rubocop.yml
Outdated
| @@ -73,9 +73,6 @@ Style/Documentation: | |||
| Style/ClassAndModuleChildren: | |||
| Enabled: false | |||
|
|
|||
| Style/TrailingComma: | |||
| Enabled: false | |||
There was a problem hiding this comment.
The style violations in existing code are because of this change to the rubocop style, which shouldn't be needed for this PR.
This reverts commit cdf1ce9.
|
Hmm, picked up other rubycop with me, fixed. |
dylanahsmith
approved these changes
Aug 18, 2017
|
@dylanahsmith @fw42 thanks, that was rather fast from PR to acceptance 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables which are defined but have a nil value should not raise.
See #749