Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support miles and kilometers #85

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Support miles and kilometers #85

merged 2 commits into from
Aug 23, 2017

Conversation

disaacs
Copy link
Contributor

@disaacs disaacs commented Mar 30, 2017

Adding support for miles and kilometers, which can be used for risk calculations.

@thegedge for review

@thegedge
Copy link
Contributor

thegedge commented Mar 30, 2017

Thanks for the PR!

This is good to merge, but we'll hold off on doing so until we get 2.0 out. After that I'll merge and likely be adding a bunch more units to Length / Weight so that they're comprehensive (and hence, desirable to have by default 😄)

Copy link
Member

@kmcphillips kmcphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! Work is good, but we'll hold off very briefly to get 2.0 released.

@thegedge
Copy link
Contributor

thegedge commented May 5, 2017

I've rebased and made use of the si_unit helper to define kilometers et al.

@thegedge
Copy link
Contributor

If no complaints, I'll go ahead and merge this one tomorrow!

@thegedge thegedge self-assigned this May 30, 2017
@thegedge thegedge self-requested a review May 30, 2017 17:46
@lucasuyezu lucasuyezu merged commit 56bcee7 into master Aug 23, 2017
@lucasuyezu lucasuyezu deleted the add-km-and-mi branch August 23, 2017 15:41
lucasuyezu added a commit that referenced this pull request Aug 23, 2017
- Added support miles and kilometers:
  #85.
@lucasuyezu lucasuyezu mentioned this pull request Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants