Bump version to 2.4.0 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the pattern from the last bump: #107
I think a minor version bump is most appropriate in this case.
The relevant PR is this one: #116
I contextualize the change as a new, backwards-compatible feature that allows the scopes returned with the token to be different than those requested. Since this relaxes a restriction, it will not break OAuth flows that are currently succeeding (and will only allow additional configurations to succeed).
There are cases where a behavioural change such as this could be construed as a breaking change, i.e. if users were relying on a validation to enforce an important security requirement.
In this case, we've determined that there's no legitimate business or security reason for Shopify apps to enforce this check. Thus, we do not need to concern ourselves with the behavioural change when considering semver.