Skip to content

Commit

Permalink
remove shopify/shopify specific message (#14)
Browse files Browse the repository at this point in the history
remove shopify/shopify specific message
  • Loading branch information
Philip Müller authored Jan 7, 2020
2 parents 0bf3f6a + 6499b01 commit 2374726
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion lib/rubocop/cop/packwerk/cop.rb
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ def check_reference(reference, node)
node,
message:
"#{message}\n" \
"More details on this check: https://bit.ly/33ikl8W\n" \
"Inference details: '#{node.source}' refers to #{constant.name} which seems to be defined in " \
"#{constant.location}.\n"
)
Expand Down
2 changes: 0 additions & 2 deletions test/cop_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ class CopTest < ActiveSupport::TestCase
expected = <<~EXPECTED
Privacy violation: '::Order' is private to 'components/sales' but referenced from 'components/timeline'.
Is there a public entrypoint in 'components/sales/app/public/' that you can use instead?
More details on this check: https://bit.ly/33ikl8W
Inference details: 'Order' refers to ::Order which seems to be defined in components/sales/app/models/order.rb.
EXPECTED
assert_equal(expected, @cop.offenses.first.message)
Expand All @@ -53,7 +52,6 @@ class CopTest < ActiveSupport::TestCase
expected = <<~EXPECTED
Privacy violation: '::Order' is private to 'components/sales' but referenced from 'components/timeline'.
Is there a public entrypoint in 'components/sales/app/public/' that you can use instead?
More details on this check: https://bit.ly/33ikl8W
Inference details: 'has_many :orders' refers to ::Order which seems to be defined in components/sales/app/models/order.rb.
EXPECTED
assert_equal(expected, @cop.offenses.first.message)
Expand Down

0 comments on commit 2374726

Please sign in to comment.