Bump sorbet and sorbet-runtime to address change of public API on newest version of sorbet-runtime #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterm
reviewed
Apr 22, 2022
| @@ -12,7 +12,7 @@ class PackageSet | |||
| extend T::Generic | |||
| include Enumerable | |||
|
|
|||
| Elem = type_member(fixed: Package) | |||
| Elem = type_member { { fixed: Package } } | |||
There was a problem hiding this comment.
Ruby syntax strikes again... This is a block returning a hash. It took me a second to realize that.
exterm
approved these changes
Apr 22, 2022
rporrasluc
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
See #200 for more info.
TLDR:
sorbet-runtime's public API changed, so this explicitly bumpssorbet-runtime, sets a version constraint, and migrates the offending use of public API inpackwerk.What approach did you choose and why?
I decided to constrain the version of
sorbet-runtime.bin/packwerk checkwould fail for clients because it would employ the wrong API oftype_memberon their older version ofsorbet-runtime.This change requires the user to bump
sorbet-runtime.What should reviewers focus on?
Let me know if I'm missing something. Another approach might be to just migrate
PackageSetoff oftype_memberso we don't have to bumpsorbet-runtime.Type of Change
Additional Release Notes
Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.
If no additional notes are necessary, delete this section or leave it unchanged.
Checklist