Apply suggestions from code review

Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Co-authored-by: Marc Thomas <marc.thomas@shopify.com>

Author: 3 people

.changeset/strange-bananas-obey.md

@@ -2,4 +2,4 @@
 '@shopify/polaris': minor
 ---
 
-Add Edit Columns button on `IndexFilters` when showEditColumns flag is true
+Added the `showEditColumnsButton` prop to `IndexFilters`

polaris-react/locales/en.json

@@ -194,7 +194,7 @@
         }
       },
       "EditColumnsButton": {
-        "editColumns": "Edit columns"
+        "accessibilityLabel": "Customize table column order and visibility"
       },
       "UpdateButtons": {
         "cancel": "Cancel",

polaris-react/src/components/IndexFilters/IndexFilters.tsx

@@ -103,8 +103,8 @@ export interface IndexFiltersProps
   closeOnChildOverlayClick?: boolean;
   /** Optional override to the default keyboard shortcuts available */
   disableKeyboardShortcuts?: boolean;
-  /** Shows the edit columns button  */
-  showEditColumns?: boolean;
+  /** Whether to display the edit columns button with the other default mode filter actions */
+  showEditColumnsButton?: boolean;
 }
 
 export function IndexFilters({
@@ -143,7 +143,7 @@ export function IndexFilters({
   hideQueryField,
   closeOnChildOverlayClick,
   disableKeyboardShortcuts,
-  showEditColumns,
+  showEditColumnsButton,
 }: IndexFiltersProps) {
   const i18n = useI18n();
   const {mdDown} = useBreakpoints();
@@ -288,7 +288,7 @@ export function IndexFilters({
     beginEdit(IndexFiltersMode.EditingColumns);
   }
 
-  const editColumnsMarkup = showEditColumns ? (
+  const editColumnsMarkup = showEditColumnsButton ? (
     <EditColumnsButton
       onClick={handleClickEditColumnsButon}
       disabled={disabled}

polaris-react/src/components/IndexFilters/components/EditColumnsButton/EditColumnsButton.tsx

@@ -33,7 +33,7 @@ export function EditColumnsButton({onClick, disabled}: EditColumnsButtonProps) {
         onClick={onClick}
         icon={polarisSummerEditions2023 ? Columns3Minor : undefined}
         label={i18n.translate(
-          'Polaris.IndexFilters.EditColumnsButton.editColumns',
+          'Polaris.IndexFilters.EditColumnsButton.accessibilityLabel',
         )}
         disabled={disabled}
       >

polaris-react/src/components/IndexFilters/tests/IndexFilters.test.tsx

@@ -441,7 +441,7 @@ describe('IndexFilters', () => {
   });
 
   describe('EditColumnsButton', () => {
-    it('renders when showEditColumns is true', () => {
+    it('renders when showEditColumnsButton is true', () => {
       const wrapper = mountWithApp(
         <IndexFilters {...defaultProps} showEditColumns />,
       );