Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Styles] Consolidate se23 styles in polaris-react/src/styles #10193

Closed
4 of 5 tasks
Tracked by #9915
sophschneider opened this issue Aug 23, 2023 · 2 comments · Fixed by #10635
Closed
4 of 5 tasks
Tracked by #9915

[Styles] Consolidate se23 styles in polaris-react/src/styles #10193

sophschneider opened this issue Aug 23, 2023 · 2 comments · Fixed by #10635
Assignees
@laurkim
Labels
Priority: High Clear visual regression, broken logic, or feature UX will feel broken without

Comments

@sophschneider
Copy link
Contributor

sophschneider commented Aug 23, 2023 •
edited by laurkim
Loading

in _common.scss we can remove $se23ShadowBevelOptOut but not $se23 since a lot of our consuming repos still use the classname and we don't want to affect their styles.

We should also add a comment above the $se23 definition telling consumers to not use and the date that it will be officially deprecated. Lets also add a calendar event or something for the day we will deprecate, and create clean up comms to consumer on the date they should finish their cleanup by

Sources:

Tasks:

  • remove $se23ShadowBevelOptOut
  • keep $se23
  • determine deprecation date for $se23
  • add comment above $se23 definition with warning not to use and deprecation date
  • add deprecation date in our calendar
@sophschneider sophschneider mentioned this issue Aug 23, 2023
Closed
@laurkim
Copy link
Contributor

laurkim commented Aug 28, 2023 •
edited
Loading

Blocked by #10189.

@laurkim laurkim assigned laurkim and unassigned laurkim Aug 28, 2023
@sophschneider
Copy link
Contributor Author

Added an issue description for keeping the se23 classname for v12

@sophschneider sophschneider mentioned this issue Sep 13, 2023
Closed
@sophschneider sophschneider added the Priority: High Clear visual regression, broken logic, or feature UX will feel broken without label Sep 20, 2023
@laurkim laurkim self-assigned this Sep 22, 2023
@laurkim laurkim mentioned this issue Sep 22, 2023
Merged
5 tasks
@laurkim laurkim linked a pull request Sep 22, 2023 that will close this issue
[AppProvider] Consolidate se23 logic #10635
Merged
5 tasks
laurkim added a commit that referenced this issue Sep 22, 2023
@laurkim
[AppProvider] Consolidate se23 logic (#10635)
340e36e 
### WHY are these changes introduced?

Resolves #9915.
Resolves #10189.
Resolves #10190.
Resolves #10192.
Resolves #10193.

Consolidates se23 logic (passing in `polarisSummerEditions2023` to
`features`) in AppProvider and related components.

### WHAT is this pull request doing?

Removes se23 flag from features and consolidates se23 comments.
Adds comment with warning to discourage use of `se23` flag in
`_common.scss`.

### How to 🎩

[Storybook]()
[Next branch
storybook](https://5d559397bae39100201eedc1-kzivkxiyci.chromatic.com/?path=/story/playground--details-page)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@laurkim laurkim closed this as completed Sep 22, 2023
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
@laurkim
[AppProvider] Consolidate se23 logic (Shopify#10635)
d2288d8 
### WHY are these changes introduced?

Resolves Shopify#9915.
Resolves Shopify#10189.
Resolves Shopify#10190.
Resolves Shopify#10192.
Resolves Shopify#10193.

Consolidates se23 logic (passing in `polarisSummerEditions2023` to
`features`) in AppProvider and related components.

### WHAT is this pull request doing?

Removes se23 flag from features and consolidates se23 comments.
Adds comment with warning to discourage use of `se23` flag in
`_common.scss`.

### How to 🎩

[Storybook]()
[Next branch
storybook](https://5d559397bae39100201eedc1-kzivkxiyci.chromatic.com/?path=/story/playground--details-page)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurkim laurkim

Labels
Priority: High Clear visual regression, broken logic, or feature UX will feel broken without
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AppProvider] Consolidate se23 logic Shopify/polaris
2 participants
@sophschneider @laurkim