Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs Component not working properly on 11.14.0 #10337

Closed
kaya-mikail opened this issue Sep 5, 2023 · 1 comment
Closed

Tabs Component not working properly on 11.14.0 #10337

kaya-mikail opened this issue Sep 5, 2023 · 1 comment
Labels
Bug Something is broken and not working as intended in the system. Component Priority: High Clear visual regression, broken logic, or feature UX will feel broken without

Comments

@kaya-mikail
Copy link

Issue summary

  1. "fitted" prop does not work, when Tabs are rendered with actions
  2. Console is returning error:
    Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
    Check the render method of Modal.
@gavin-hinchley gavin-hinchley mentioned this issue Sep 15, 2023
Closed
@chloerice chloerice added Priority: High Clear visual regression, broken logic, or feature UX will feel broken without Component Bug Something is broken and not working as intended in the system. and removed untriaged labels Sep 15, 2023
@yurm04
Copy link
Contributor

yurm04 commented Jan 5, 2024

I believe this issue was resolved with #11266. I tested the Modal and Tabs with actions stories in the storybook and could no longer replicate the error. The fitted prop in Tabs also seems to work as expected. Going to close this issue. @kaya-mikail if you continue to experience this issue after updating to the latest version of Polaris, please feel free to reopen.

@yurm04 yurm04 closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something is broken and not working as intended in the system. Component Priority: High Clear visual regression, broken logic, or feature UX will feel broken without
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yurm04 @chloerice @alex-page @kaya-mikail