New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Help Documentation #1543

Closed

sarahill opened this issue May 21, 2019 · 6 comments

Assignees

Contributor

sarahill commented May 21, 2019 •

edited

Loading

Updates to help documentation related to list filters

https://help.shopify.com/en/manual/orders/fulfill-orders

cc: @VanjaMitrovic @sadiesaurus

sarahill added the 🌟List Filters label

Contributor

tmlayton commented May 21, 2019

There might be other pages, too. That was just the first one I could find.

Contributor

dpersing commented May 29, 2019

@sarahill Do we have enough info on how to do this to start? I seem to recall there's an email address to ping with Help Center requests.

Contributor

tmlayton commented Aug 13, 2019

Just bumping on this one, we are wrapping up the outstanding items on the project this week so if someone could pick this up that would be amazing

VanjaMitrovic commented Aug 15, 2019

The docs are done but are hidden. I'll unhide them in the help repo.
https://help.shopify.com/en/manual/orders/new-filters

VanjaMitrovic assigned halligators

VanjaMitrovic commented Aug 15, 2019

@halligators will take care of the content in the Help Center. thanks, Hal!

VanjaMitrovic commented Aug 19, 2019

Fixed! https://github.com/Shopify/help/pull/10016

VanjaMitrovic closed this as completed

laurkim added a commit that referenced this issue


          [ContextualSaveBar] Fix logo spacing (#11789)

36df1aa

### WHY are these changes introduced?

Resolves
[#1543](https://github.com/Shopify/polaris-internal/issues/1543).

### WHAT is this pull request doing?

Fixes layout shift on logo container from spacing inconsistency.
<details>
    <summary>ContextualSaveBar — before</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/a6523e71-b9f1-448a-a3a4-b9914a804d08"
alt="ContextualSaveBar — before">
  </details>
<details>
    <summary>ContextualSaveBar — after</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/d4a0f770-aba0-4645-8230-95f174ef42f0"
alt="ContextualSaveBar — after">
  </details>

### How to 🎩

[Spin
URL](https://admin.web.fix-contextual-save-bar.lo-kim.us.spin.dev/store/shop1/products/new)
Add a new product but discard changes.

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue


          [ContextualSaveBar] Fix logo spacing (Shopify#11789)

d6f7ab6

### WHY are these changes introduced?

Resolves
[Shopify#1543](https://github.com/Shopify/polaris-internal/issues/1543).

### WHAT is this pull request doing?

Fixes layout shift on logo container from spacing inconsistency.
<details>
    <summary>ContextualSaveBar — before</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/a6523e71-b9f1-448a-a3a4-b9914a804d08"
alt="ContextualSaveBar — before">
  </details>
<details>
    <summary>ContextualSaveBar — after</summary>
<img
src="https://github.com/Shopify/polaris/assets/26749317/d4a0f770-aba0-4645-8230-95f174ef42f0"
alt="ContextualSaveBar — after">
  </details>

### How to 🎩

[Spin
URL](https://admin.web.fix-contextual-save-bar.lo-kim.us.spin.dev/store/shop1/products/new)
Add a new product but discard changes.

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment