-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v12-react-avatar-component
migration
#10874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgriffee
requested review from
sam-b-rose,
sophschneider,
laurkim and
aaronccasanova
October 4, 2023 17:13
laurkim
reviewed
Oct 4, 2023
sophschneider
approved these changes
Oct 4, 2023
laurkim
approved these changes
Oct 4, 2023
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-Authored-By: Lo Kim <26749317+laurkim@users.noreply.github.com>
…into avatar-migration
sam-b-rose
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Merged
lgriffee
pushed a commit
that referenced
this pull request
Oct 4, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.24.0 ### Minor Changes - [#10874](#10874) [`471c3d5af`](471c3d5) Thanks [@lgriffee](https://github.com/lgriffee)! - Ported `v12-react-avatar-component` migration from [Avatar] Remove customer prop and experimental values [#10283](#10283) to main branch Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
In order to run the `v12-react-avatar-component` migration as part of our beta release it needs to be merged and released on `main` instead of the `next` branch. Ports over `v12-react-avatar-component` migration from [[Avatar] Remove customer prop and experiemntal values --------- Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Lo Kim <26749317+laurkim@users.noreply.github.com>
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.24.0 ### Minor Changes - [#10874](#10874) [`471c3d5af`](471c3d5) Thanks [@lgriffee](https://github.com/lgriffee)! - Ported `v12-react-avatar-component` migration from [Avatar] Remove customer prop and experimental values [#10283](#10283) to main branch Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
In order to run the `v12-react-avatar-component` migration as part of our beta release it needs to be merged and released on `main` instead of the `next` branch. Ports over `v12-react-avatar-component` migration from [[Avatar] Remove customer prop and experiemntal values --------- Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Lo Kim <26749317+laurkim@users.noreply.github.com>
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.24.0 ### Minor Changes - [#10874](#10874) [`471c3d5af`](471c3d5) Thanks [@lgriffee](https://github.com/lgriffee)! - Ported `v12-react-avatar-component` migration from [Avatar] Remove customer prop and experimental values [#10283](#10283) to main branch Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? In order to run the `v12-react-avatar-component` migration as part of our beta release it needs to be merged and released on `main` instead of the `next` branch. ### WHAT is this pull request doing? Ports over `v12-react-avatar-component` migration from [[Avatar] Remove customer prop and experiemntal values Shopify#10283](Shopify#10283) to main branch --------- Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Lo Kim <26749317+laurkim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
In order to run the
v12-react-avatar-component
migration as part of our beta release it needs to be merged and released onmain
instead of thenext
branch.WHAT is this pull request doing?
Ports over
v12-react-avatar-component
migration from [Avatar] Remove customer prop and experiemntal values #10283 to main branch