Add support for view transitions when using react-router-dom Link
#11580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
c13c9f8
to
266c5d1
Compare
laurkim
changed the title
primaryAction
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
2 times, most recently
from
5c64286
to
0ea4f3d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
5 times, most recently
from
7b8db8d
to
0d4798e
Compare
laurkim
changed the title
primaryActionreact-router-dom Link
6 tasks
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
0d4798e
to
d32c805
Compare
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
2 times, most recently
from
2cba91a
to
bfde1a0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
3b2f505
to
0c9f8f4
Compare
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
0c9f8f4
to
2874c76
Compare
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
2874c76
to
43bed25
Compare
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
43bed25
to
3c64735
Compare
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
changed the title
react-router-dom Link
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
e707ba1
to
1669121
Compare
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
changed the title
laurkim
changed the title
react-router-dom Link
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
1669121
to
6358c4c
Compare
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
6358c4c
to
08e67b4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
laurkim
force-pushed
the
lo/add-view-transitions-support
branch
from
08e67b4
to
39fb840
Compare
|
/snapit |
|
🫰✨ Thanks @laurkim! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-icons": "0.0.0-snapshot-20240424142930",
"@shopify/polaris-migrator": "0.0.0-snapshot-20240424142930",
"@shopify/polaris": "0.0.0-snapshot-20240424142930",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240424142930",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240424142930" |
|
Closing as this is being implemented in admin directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #1499.
Add support for view transitions with new
viewTransitionprop on:Removes progress bar aka Loading from Frame and all references to it in
polaris-reactandpolaris.shopify.com.Updates transitions for Navigation to improve snappiness and UX.
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes