[IndexTable.Row] Revert selectable=false early return, which break on… #11773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloerice
force-pushed
the
revert-navigation-logic-only-working-when-selectable
branch
from
b5b0f1c
to
84a5c60
Compare
…Navigation for unselectable tables
chloerice
force-pushed
the
revert-navigation-logic-only-working-when-selectable
branch
from
84a5c60
to
5233dcf
Compare
chloerice
deleted the
revert-navigation-logic-only-working-when-selectable
branch
Merged
chloerice
pushed a commit
that referenced
this pull request
Mar 21, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@12.22.1 ### Patch Changes - [#11771](#11771) [`8d636390a`](8d63639) Thanks [@kyledurand](https://github.com/kyledurand)! - Added cover positioning story to popover to prevent regressions - [#11773](#11773) [`b1a0efc7d`](b1a0efc) Thanks [@chloerice](https://github.com/chloerice)! - Reverted a change that caused `IndexTable` `onNavigation` not to work when `selectable` is `false` ## polaris.shopify.com@0.66.1 ### Patch Changes - Updated dependencies \[[`8d636390a`](8d63639), [`b1a0efc7d`](b1a0efc)]: - @shopify/polaris@12.22.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Shopify#11773) ### WHAT is this pull request doing? This PR reverts a change made in Shopify#11763, unrelated to the bug fixed, that caused an unintended regression: breaking `onNavigation` behavior for unselectable tables. This needs to ship in a patch asap because it is live in v12.20.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
This PR reverts a change made in #11763, unrelated to the bug fixed, that caused an unintended regression: breaking
onNavigationbehavior for unselectable tables. This needs to ship in a patch asap because it is live in v12.20.0.