[Filters] Add support for indicating an applied filter has unsaved changes #11783
+799
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
chloerice
force-pushed
the
index-filter-pill-improvements
branch
2 times, most recently
from
497b1f5
to
c55d45f
Compare
chloerice
force-pushed
the
index-filter-pill-improvements
branch
3 times, most recently
from
68ed7bf
to
15b521f
Compare
chloerice
changed the title
|
/snapit |
|
🫰✨ Thanks @chloerice! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-icons": "0.0.0-snapshot-20240404202825"
"@shopify/polaris-migrator": "0.0.0-snapshot-20240404202825"
"@shopify/polaris": "0.0.0-snapshot-20240404202825" |
mrcthms
approved these changes
Apr 5, 2024
chloerice
force-pushed
the
index-filter-pill-improvements
branch
2 times, most recently
from
fcf5e6b
to
e73fa76
Compare
chloerice
force-pushed
the
index-filter-pill-improvements
branch
from
e73fa76
to
829dfe9
Compare
davidlng
approved these changes
Apr 5, 2024
Merged
aaronccasanova
pushed a commit
that referenced
this pull request
Apr 9, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.29.0 ### Minor Changes - [#11831](#11831) [`99972a50b`](99972a5) Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to replace deprecated `text` custom properties in polaris-react v14.0.0 ## @shopify/polaris@12.27.0 ### Minor Changes - [#11783](#11783) [`0bf817afc`](0bf817a) Thanks [@chloerice](https://github.com/chloerice)! - Added support to `Filters` for indicating `appliedFilters` have unsaved changes ### Patch Changes - [#11824](#11824) [`79130eeea`](79130ee) Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Lint fixes - [#11845](#11845) [`8145d7326`](8145d73) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `touch-action: manipulation` to `Button` and `Link` - Updated dependencies \[[`79130eeea`](79130ee)]: - @shopify/polaris-icons@8.11.1 ## @shopify/polaris-icons@8.11.1 ### Patch Changes - [#11824](#11824) [`79130eeea`](79130ee) Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Added missing `svgo` dev dependency ## polaris.shopify.com@0.67.4 ### Patch Changes - [#11851](#11851) [`e2909baa9`](e2909ba) Thanks [@sarahill](https://github.com/sarahill)! - Updated common action guidance. - Updated dependencies \[[`0bf817afc`](0bf817a), [`79130eeea`](79130ee), [`79130eeea`](79130ee), [`8145d7326`](8145d73)]: - @shopify/polaris@12.27.0 - @shopify/polaris-icons@8.11.1
chloerice
pushed a commit
that referenced
this pull request
Apr 10, 2024
This PR adds async translations requested in #11783, which was opened by @chloerice. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/11783/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=11783` Translation Platform will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=11783` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Please tag the translation component owners, `@Shopify/polaris-eng`, if you need someone to review this PR. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…anges (Shopify#11783) ### WHY are these changes introduced? Part of Shopify/web#76490 ### WHAT is this pull request doing? Adds support for indicating unsaved changes have been made to the applied filters.  ### How to 🎩 📚 [Storybook](https://5d559397bae39100201eedc1-fbscsztkor.chromatic.com/?path=/story/all-components-filters--with-children-content-and-unsaved-changes) 🌀 [Spinstance](https://admin.web.unsaved-indexfilter-changes.chloe-rice.us.spin.dev/store/shop1/products?selectedView=all&status=ACTIVE) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
This PR adds async translations requested in Shopify#11783, which was opened by @chloerice. It will append multiple commits and may add, modify, or delete translations. Feel free to merge the PR any time; we'll open a new PR if any more translations come in. [Check the source PR's overall translation progress here.](https://translation-platform.shopify.io/repos/Shopify/polaris/pulls/11783/progress) ## Before you deploy - Check translations for malicious HTML. ## Merge conflicts? <details> If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order: 1. Close this PR. 2. Run the following Spy command in Slack: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=11783` Translation Platform will recreate the translation commits based on the latest commit on the base branch and open a new PR. </details> ## Missing completed translations? <details> If the translations were completed within the last several hours, Translation Platform may just be holding on to them for a bit to see if any others come in before creating a commit (multiple file changes are committed together to reduce noise). If it's been a while and completed translations are still missing, or if you're just in a hurry, you can run the following Spy command in Slack to download or re-download any completed translations to this PR: > `@spy translation-platform force-pull Shopify/polaris pull_request_number=11783` - The translations might have been added to the source PR, but the PR was rebased before it was shipped and the translations were accidentally dropped. - A later change to the translation files might have overwritten the previously downloaded translations. - Translation Platform might have failed to download the translations-- if you suspect this to be the case, please reach out at the link below. </details> ## Questions? Visit [#help-localization](https://shopify.slack.com/messages/C7TJQLVC7) for questions about this pull request. Please tag the translation component owners, `@Shopify/polaris-eng`, if you need someone to review this PR. Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/web/issues/76490
WHAT is this pull request doing?
Adds support for indicating unsaved changes have been made to the applied filters.
How to 🎩
📚 Storybook
🌀 Spinstance
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes