[polaris.shopify.com] Refactor site search (ready for review) #6502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martenbjork
changed the title
martenbjork
changed the title
alex-page
force-pushed
the
main
branch
7 times, most recently
from
a3a40bb to
0281d22
Compare
martenbjork
changed the title
martenbjork
changed the title
martenbjork
changed the title
alex-page
approved these changes
Jul 20, 2022
alex-page
reviewed
Jul 20, 2022
| }, | ||
| "intro": "Our mission is to make commerce better for _everyone_. Building products for everyone means creating inclusive content.", | ||
| "section": "content" | ||
| "category": "content" |
There was a problem hiding this comment.
Love the consolidation here. I was unsure why it's called content but this is fine for now.
There was a problem hiding this comment.
The category maps to the folder that the foundations content lives in: foundations | design | content | patterns.
alex-page
reviewed
Jul 20, 2022
Comment on lines
+19
to
+22
| components: "Components", | ||
| foundations: "Foundations", | ||
| tokens: "Tokens", | ||
| icons: "Icons", |
There was a problem hiding this comment.
Do we need this? Could just be uppercase the key function
There was a problem hiding this comment.
I know, it was tempting to remove this very verbose part of the code. It just feels icky to hide the translations strings and make assumptions about language. If we add a more complex search result type like, GitHub repos, it's nice to be able to be explicit about capitalization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the code that powers the global search. The new code is still complex, but less so. Implementing new types of search results is also easier thanks to the simpler
useGlobalSearchResults()hook.UX updates
This refactor shouldn't change the search experience much. One update however, is that foundations results now render with the correct icon / color.
Related to #6529, this PR also increases the number of search results that are visible for each category, which fixes #6546.
Also fixes #6463.