Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Conversation

aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented Jan 5, 2023

This PR introduces a wrapper around the built-in Stylelint declartion-property-value-disallowed-list rule to ignore failures in @font-face at-rules. The issue is described further in #7991

@aaronccasanova aaronccasanova changed the title Create polaris/typography-declaration-proprety-value-disallowed-list Stylelint rule Create polaris/typography-declaration-property-value-disallowed-list Stylelint rule Jan 5, 2023
@aaronccasanova aaronccasanova self-assigned this Jan 5, 2023
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great-simple and clean! Thanks for adding the test as well. Nice work 💯

@sam-b-rose
Copy link
Member

Fixes #7991

@aaronccasanova aaronccasanova changed the title Create polaris/typography-declaration-property-value-disallowed-list Stylelint rule Create polaris/declaration-property-value-disallowed-list Stylelint rule Jan 5, 2023
@aaronccasanova aaronccasanova marked this pull request as ready for review January 5, 2023 22:59
Copy link
Contributor

@sophschneider sophschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bug catch and nice solution! thanks for the test cases, helped to understand the problem :)

@aaronccasanova aaronccasanova merged commit 128f147 into main Jan 6, 2023
@aaronccasanova aaronccasanova deleted the custom-typography-rule branch January 6, 2023 18:18
kyledurand pushed a commit that referenced this pull request Jan 11, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.19.0

### Minor Changes

- [#7817](#7817)
[`6c310101d`](6c31010)
Thanks [@henryyi](https://github.com/henryyi)! - Added
`secondaryActions` prop in Navigation.Item to support up to two actions

### Patch Changes

- [#8018](#8018)
[`2620b0a20`](2620b0a)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed modal
scroll bug

## @shopify/stylelint-polaris@5.1.0

### Minor Changes

- [#7993](#7993)
[`128f147d1`](128f147)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created
`polaris/declaration-property-value-disallowed-list` rule to ignore
failures in `@font-face` at-rules

### Patch Changes

- [#8006](#8006)
[`6404b1638`](6404b16)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! -
Temporarily disabled `border-radius-base` error

## @shopify/plugin-polaris@0.0.26

### Patch Changes

- Updated dependencies
\[[`fad3809ef`](fad3809),
[`56b0bc2dc`](56b0bc2)]:
    -   @shopify/polaris-migrator@0.10.3

## @shopify/polaris-migrator@0.10.3

### Patch Changes

- [#7997](#7997)
[`fad3809ef`](fad3809)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated
`styles-tokenize-font` to ignore `@font-face` at-rules


- [#7783](#7783)
[`56b0bc2dc`](56b0bc2)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Improve
robustness of the `react-replace-text-components` migration

- Updated dependencies
\[[`6404b1638`](6404b16),
[`128f147d1`](128f147)]:
    -   @shopify/stylelint-polaris@5.1.0

## polaris.shopify.com@0.28.3

### Patch Changes

- Updated dependencies
\[[`2620b0a20`](2620b0a),
[`6c310101d`](6c31010)]:
    -   @shopify/polaris@10.19.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gwyneplaine gwyneplaine mentioned this pull request Feb 14, 2023
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.19.0

### Minor Changes

- [Shopify#7817](Shopify#7817)
[`6c310101d`](Shopify@6c31010)
Thanks [@henryyi](https://github.com/henryyi)! - Added
`secondaryActions` prop in Navigation.Item to support up to two actions

### Patch Changes

- [Shopify#8018](Shopify#8018)
[`2620b0a20`](Shopify@2620b0a)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed modal
scroll bug

## @shopify/stylelint-polaris@5.1.0

### Minor Changes

- [Shopify#7993](Shopify#7993)
[`128f147d1`](Shopify@128f147)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created
`polaris/declaration-property-value-disallowed-list` rule to ignore
failures in `@font-face` at-rules

### Patch Changes

- [Shopify#8006](Shopify#8006)
[`6404b1638`](Shopify@6404b16)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! -
Temporarily disabled `border-radius-base` error

## @shopify/plugin-polaris@0.0.26

### Patch Changes

- Updated dependencies
\[[`fad3809ef`](Shopify@fad3809),
[`56b0bc2dc`](Shopify@56b0bc2)]:
    -   @shopify/polaris-migrator@0.10.3

## @shopify/polaris-migrator@0.10.3

### Patch Changes

- [Shopify#7997](Shopify#7997)
[`fad3809ef`](Shopify@fad3809)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated
`styles-tokenize-font` to ignore `@font-face` at-rules


- [Shopify#7783](Shopify#7783)
[`56b0bc2dc`](Shopify@56b0bc2)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Improve
robustness of the `react-replace-text-components` migration

- Updated dependencies
\[[`6404b1638`](Shopify@6404b16),
[`128f147d1`](Shopify@128f147)]:
    -   @shopify/stylelint-polaris@5.1.0

## polaris.shopify.com@0.28.3

### Patch Changes

- Updated dependencies
\[[`2620b0a20`](Shopify@2620b0a),
[`6c310101d`](Shopify@6c31010)]:
    -   @shopify/polaris@10.19.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants